MrEasy commented on code in PR #4708:
URL: https://github.com/apache/activemq-artemis/pull/4708#discussion_r1420214338
##########
artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/client/ActiveMQClient.java:
##########
@@ -309,7 +306,7 @@ public static int getGlobalScheduledThreadPoolSize() {
*/
public static void initializeGlobalThreadPoolProperties() {
-
setGlobalThreadPoolProperties(Integer.valueOf(System.getProperty(ActiveMQClient.THREAD_POOL_MAX_SIZE_PROPERTY_KEY,
"" + ActiveMQClient.DEFAULT_GLOBAL_THREAD_POOL_MAX_SIZE)),
Integer.valueOf(System.getProperty(ActiveMQClient.SCHEDULED_THREAD_POOL_SIZE_PROPERTY_KEY,
"" + ActiveMQClient.DEFAULT_SCHEDULED_THREAD_POOL_MAX_SIZE)));
+
setGlobalThreadPoolProperties(Integer.valueOf(System.getProperty(ActiveMQClient.THREAD_POOL_MAX_SIZE_PROPERTY_KEY,
"" + ActiveMQClient.DEFAULT_GLOBAL_THREAD_POOL_MAX_SIZE)),
Integer.valueOf(System.getProperty(ActiveMQClient.SCHEDULED_THREAD_POOL_SIZE_PROPERTY_KEY,
"" + ActiveMQClient.DEFAULT_SCHEDULED_THREAD_POOL_MAX_SIZE)),
Integer.valueOf(System.getProperty(ActiveMQClient.FLOW_CONTROL_THREAD_POOL_SIZE_PROPERTY_KEY,
"" + ActiveMQClient.DEFAULT_FLOW_CONTROL_THREAD_POOL_MAX_SIZE)));
Review Comment:
Integer.parseInt would avoid the boxing
##########
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/ActiveMQClientLogger.java:
##########
@@ -347,4 +347,7 @@ public interface ActiveMQClientLogger {
@LogMessage(id = 214034, value = "{} has negative counts {}\n{}", level =
LogMessage.Level.ERROR)
void negativeRefCount(String message, String count, String debugString);
+
+ @LogMessage(id = 214035, value = "Couldn't finish the client
globalFlowControlThreadPool in less than 10 seconds, interrupting it now",
level = LogMessage.Level.WARN)
Review Comment:
thanks for the added warning.
Would recommend "Could not" instead of "Couldn't" like in other messages
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
