jbertram commented on code in PR #4708:
URL: https://github.com/apache/activemq-artemis/pull/4708#discussion_r1425790869
##########
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/ActiveMQClientLogger.java:
##########
@@ -347,4 +347,7 @@ public interface ActiveMQClientLogger {
@LogMessage(id = 214034, value = "{} has negative counts {}\n{}", level =
LogMessage.Level.ERROR)
void negativeRefCount(String message, String count, String debugString);
+
+ @LogMessage(id = 214035, value = "Couldn't finish the client
globalFlowControlThreadPool in less than 10 seconds, interrupting it now",
level = LogMessage.Level.WARN)
Review Comment:
My change follows the established pattern of using "Couldn't finish the..."
in the other messages related to stopping the other global thread pools. I
would be fine with changing this to use `Could not`, but it would need to be in
another commit that changes the pattern for every use here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
