jbertram commented on code in PR #4708:
URL: https://github.com/apache/activemq-artemis/pull/4708#discussion_r1425789366
##########
artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/client/ActiveMQClient.java:
##########
@@ -309,7 +306,7 @@ public static int getGlobalScheduledThreadPoolSize() {
*/
public static void initializeGlobalThreadPoolProperties() {
-
setGlobalThreadPoolProperties(Integer.valueOf(System.getProperty(ActiveMQClient.THREAD_POOL_MAX_SIZE_PROPERTY_KEY,
"" + ActiveMQClient.DEFAULT_GLOBAL_THREAD_POOL_MAX_SIZE)),
Integer.valueOf(System.getProperty(ActiveMQClient.SCHEDULED_THREAD_POOL_SIZE_PROPERTY_KEY,
"" + ActiveMQClient.DEFAULT_SCHEDULED_THREAD_POOL_MAX_SIZE)));
+
setGlobalThreadPoolProperties(Integer.valueOf(System.getProperty(ActiveMQClient.THREAD_POOL_MAX_SIZE_PROPERTY_KEY,
"" + ActiveMQClient.DEFAULT_GLOBAL_THREAD_POOL_MAX_SIZE)),
Integer.valueOf(System.getProperty(ActiveMQClient.SCHEDULED_THREAD_POOL_SIZE_PROPERTY_KEY,
"" + ActiveMQClient.DEFAULT_SCHEDULED_THREAD_POOL_MAX_SIZE)),
Integer.valueOf(System.getProperty(ActiveMQClient.FLOW_CONTROL_THREAD_POOL_SIZE_PROPERTY_KEY,
"" + ActiveMQClient.DEFAULT_FLOW_CONTROL_THREAD_POOL_MAX_SIZE)));
Review Comment:
My change follows the established pattern of using `Integer.valueOf`. I
would be fine with changing this to use `Integer.parseInt`, but it would need
to be in another commit that changes the pattern for every use here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
