ggkochanski commented on code in PR #1285:
URL: https://github.com/apache/activemq/pull/1285#discussion_r1728777302
##########
activemq-client/src/main/java/org/apache/activemq/management/StatisticImpl.java:
##########
@@ -80,6 +80,9 @@ public synchronized long getLastSampleTime() {
return this.lastSampleTime;
}
+ public synchronized long getLastSampleTimeOrStartTime(){
+ return lastSampleTime == 0 ? startTime : lastSampleTime;
Review Comment:
wow, that's clever 😊
it's much better,
we may even skip generation of
`statsMessage.setLong("lastMessageTimestamp",
stats.getEnqueues().getLastSampleTime())`
when it's not "hasUpdated" 😋
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
