mattrpav commented on code in PR #1285:
URL: https://github.com/apache/activemq/pull/1285#discussion_r1771914221
##########
activemq-broker/src/main/java/org/apache/activemq/plugin/StatisticsBroker.java:
##########
@@ -160,6 +160,11 @@ else if (dest instanceof Topic) {
tempFirstMessage.clear();
}
}
+ if ( stats.getEnqueues().hasUpdated() ) {
+ // NOTICE: Client-side, you may get the broker
"now" Timestamp by msg.getJMSTimestamp()
+ // This allows for calculating inactivity.
+ statsMessage.setLong("lastMessageTimestamp",
stats.getEnqueues().getLastSampleTime());
Review Comment:
@ggkochanski The field naming is a broader conversation. The full scope is
not one field as you have in this PR. We currently have a number of metrics
(and config params) that are not fully aligned in naming convention, so I would
press for an organized approach for these new metrics.
Related JIRAs:
ref: https://issues.apache.org/jira/browse/AMQ-4358
ref: https://issues.apache.org/jira/browse/AMQ-5497
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
