mattrpav commented on code in PR #1285:
URL: https://github.com/apache/activemq/pull/1285#discussion_r1796134881
##########
activemq-broker/src/main/java/org/apache/activemq/plugin/StatisticsBroker.java:
##########
@@ -160,6 +160,11 @@ else if (dest instanceof Topic) {
tempFirstMessage.clear();
}
}
+ if ( stats.getEnqueues().hasUpdated() ) {
+ // NOTICE: Client-side, you may get the broker
"now" Timestamp by msg.getJMSTimestamp()
+ // This allows for calculating inactivity.
+ statsMessage.setLong("lastMessageTimestamp",
stats.getEnqueues().getLastSampleTime());
Review Comment:
@ggkochanski yeah, the challenge is settling on the terminology for the
metric values. For example, does 'last' mean last-as-in-time, or
last-as-in-last-message-in-the-queue (most recently added).
This feature will be enabled via PolicyEntry property, such as
advancedTimeStatisticsEnabled="true". This will allow existing users to not
incur the potential latency penalty and users that wish to have increased
observability can simply toggle the parameter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
