cshannon commented on PR #1364: URL: https://github.com/apache/activemq/pull/1364#issuecomment-2531953091
I don't think the changes here are going to be nearly as simple as you think, it's been a while since I've looked at this and have to review the spec again but I've talked to @tabish121 about there are a lot of things you have to take into consideration and it's not just as simple as being able to copy and paste the existing async code. Speaking of which, we should be trying to re-use code where possible and not simply copying and pasting. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact