cshannon commented on PR #1364: URL: https://github.com/apache/activemq/pull/1364#issuecomment-2535973736
As a follow up to my comment about following the spec 100% and whether we really need to meet the requirement etc... User's have been using the existing async client behavior for a very long time so I think you could also make an argument to actually just make the new Jakarta 3.1 completion listener behavior to be in line with the old behavior even even if it doesn't match the spec 100% as it preserves existing behavior and obviously is significantly less work to implement. On one hand, i think the goal should be to be 100% compliant but on the other hand it's also not like the broker has ever been fully compliant and certainly isn't compliant today with not implementing much of the spec. And there are times where I don't know how much it really matters if the spec is fully met. Anyways, I'm not sure what we should do as I'm sure there are uses cases and client code that would now break if the code expects an exact match to the spec and it deviates. Thinking about it, I don't really know how much it matters or doesn't matter that clause [7.3.8](https://jakarta.ee/specifications/messaging/3.1/jakarta-messaging-spec-3.1#use-of-the-completionlistener-by-the-jakarta-messaging-provider) is honored as it depends on what a client is trying to do, but if it wasn't honored we'd certainly need to disclose that somewhere for awareness. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
