franz1981 commented on PR #6021: URL: https://github.com/apache/activemq-artemis/pull/6021#issuecomment-3468672644
@jbertram 2 things: 1. https://github.com/apache/activemq-artemis/blob/1c1924c18b4ae6b00edbac7d3b210438c99ff5da/artemis-commons/src/test/java/org/apache/activemq/artemis/utils/ByteUtilTest.java#L234 cannot work if there's no `Unsafe` available and direct ByteBuffer so you can add an `assumeTrue(PlatformDependent.hasUnsafe()` to the test 2. If you go there it means that you are not starting artemis or the test with the "right" parameters to still use `Unsafe` in a JAVA 25 world... The former worry me a bit because it is basically saying "I can zero a buffer which is limiting how much i can write into ti" and I don't remember why I've done it TBH .-. The latter can be addressed by https://netty.io/wiki/java-24-and-sun.misc.unsafe.html#netty-42-and-unsafe i.e. `preferred` approach and configuration. But you can still enable Netty to use `Unsafe` with `--sun-misc-unsafe-memory-access=allow` AFAIK: give it a shot! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information, visit: https://activemq.apache.org/contact
