AntonRoskvist commented on code in PR #6021:
URL: https://github.com/apache/activemq-artemis/pull/6021#discussion_r2480704169
##########
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/NettyConnector.java:
##########
@@ -528,38 +534,54 @@ public synchronized void start() {
return;
}
- if (remotingThreads == -1) {
+ boolean defaultRemotingThreads = remotingThreads == -1;
+
+ if (defaultRemotingThreads) {
// Default to number of cores * 3
remotingThreads = Runtime.getRuntime().availableProcessors() * 3;
}
String connectorType;
- if (useEpoll && CheckDependencies.isEpollAvailable()) {
+ if (useIoUring && CheckDependencies.isIoUringAvailable()) {
+ //IO_URING should default to 1 remotingThread unless specified in
config
Review Comment:
IIRC, setting it to 1 was a recommendation I found back from when netty
io_uring was still an incubator project. I did some testing on this when I
submitted the previous PR and saw that using 1 thread performed best up to
something on the order of a few thousand connections and messages per second.
After that it had to be increased but as I recall it, I saw no measurable
improvement using more than just a few dedicated threads. Again, this was some
time ago but I would guess up to ~5 threads or so on a decently sized server,
say 16 cores.
Perhaps it should be set to something like
`Runtime.getRuntime().availableProcessors()` or half that number or similar?
Otherwise I guess the scaling option would make sense...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
