AntonRoskvist commented on code in PR #6021: URL: https://github.com/apache/activemq-artemis/pull/6021#discussion_r2481786217
########## artemis-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/bin/artemis: ########## Review Comment: So probably this won't be final but this can be simplified a bit, doing something like: `$JAVACMD --sun-misc-unsafe-memory-access=allow --version >/dev/null && ALLOW_UNSAFE="--sun-misc-unsafe-memory-access=allow"` in essence, `$JAVACMD --sun-misc-unsafe-memory-access=allow --version` returns 0 if the version is > 24 and 1 otherwise, meaning if the option can be set, it will get set. Could be set as part of an if statement for clarity as well... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information, visit: https://activemq.apache.org/contact
