mattrpav commented on PR #1560: URL: https://github.com/apache/activemq/pull/1560#issuecomment-3639386877
> @mattrpav maybe check another time https://github.com/apache/activemq/pull/1555/files and fork @jeanouii PR to propose your change, copying his work doesn't look fair from outside. > > Also the changes look just random (the message count, the before method is completely pointless etc) so maybe superseed this PR with this one #1555 rather than the opposite to make test suite better, no? I am always mindful to ensure contributors get credit for their efforts. In this case, the initial change needs to be reverted for correctness. Using two commits to do that does not seem productive -- the applied usage of the IOHelper is the only change. That being said, I'm happy to add a co-author credit in the commit comment if that warrants. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information, visit: https://activemq.apache.org/contact
