rmannibucau commented on PR #1560: URL: https://github.com/apache/activemq/pull/1560#issuecomment-3640757584
> The comment describes the scenario -- the queue's sequence number needs to be pushed forward to ensure correctness of the tests. this is not because it is written that it is true, you changed the number and it still passes so it is likely wrong no - at least code doesn't require it strictly and if using internal length you broke it by changing it and fake the test passes - but it doesn't test anything anymore? So either you "removed" virtually the test or it is useless, both case are wrong in current PR - my understanding is it is useless. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information, visit: https://activemq.apache.org/contact
