jeanouii commented on PR #1560: URL: https://github.com/apache/activemq/pull/1560#issuecomment-3639392586
@mattrpav but the queue where it's pushed is not the same as the queue used in the tests themselves. And the reality is that if you remove it all together, it still works, so either some asserts are missing for the tests or really this is not used. > > Can you explain why you put back the @before with send/receive of several thousands of messages? Why is this needed? > > The comment describes the scenario -- the queue's sequence number needs to be pushed forward to ensure correctness of the tests. > > ``` > // Send+Recv a odd number of messages beyond cache sizes > // to confirm the queue's sequence number gets pushed off > ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information, visit: https://activemq.apache.org/contact
