jbonofre commented on code in PR #1937:
URL: https://github.com/apache/activemq/pull/1937#discussion_r3094708331


##########
activemq-karaf/src/main/resources/features-core.xml:
##########
@@ -40,6 +40,8 @@
         <bundle 
dependency="true">mvn:org.apache.geronimo.specs/geronimo-annotation_1.3_spec/1.0</bundle>
         <bundle 
dependency="true">mvn:org.apache.geronimo.specs/geronimo-jta_1.1_spec/1.1.1</bundle>
         
<bundle>mvn:org.apache.commons/commons-pool2/${commons-pool2-version}</bundle>
+        
<bundle>mvn:org.apache.commons/commons-lang3/${commons-lang3-version}</bundle>
+        
<bundle>mvn:org.apache.commons/commons-text/${commons-text-version}</bundle>

Review Comment:
   You don't get my point: today the activemq-osgi requires commons-text 
because the web-console import leak in activemq-osgi.
   That's not in the webconsole war, it's in the activemq-osgi bundle.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact


Reply via email to