jbonofre commented on code in PR #1938: URL: https://github.com/apache/activemq/pull/1938#discussion_r3097871803
########## activemq-web/src/main/java/org/apache/activemq/web/util/ViewUtils.java: ########## @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.activemq.web.util; + +import com.rometools.rome.feed.atom.Link; +import java.util.Collections; +import java.util.LinkedHashMap; +import java.util.Map; +import java.util.Map.Entry; + +public class ViewUtils { + + public static final String AMP = "&"; + public static final String QUOTE = "\""; + public static final String LT = "<"; + public static final String GT = ">"; + public static final String APOS = "'"; + + public static final String XML_ESCAPED_AMP = "&"; + public static final String XML_ESCAPED_QUOTE = """; + public static final String XML_ESCAPED_LT = "<"; + public static final String XMl_ESCAPED_GT = ">"; Review Comment: ```suggestion public static final String XML_ESCAPED_GT = ">"; ``` ########## activemq-web/src/main/java/org/apache/activemq/web/util/ViewUtils.java: ########## @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.activemq.web.util; + +import com.rometools.rome.feed.atom.Link; Review Comment: This import is not used. I guess it was an IDE auto-completion 😄 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information, visit: https://activemq.apache.org/contact
