mattrpav commented on code in PR #1937:
URL: https://github.com/apache/activemq/pull/1937#discussion_r3094726798
##########
pom.xml:
##########
@@ -58,6 +58,8 @@
<commons-collections-version>3.2.2</commons-collections-version>
<commons-dbcp2-version>2.14.0</commons-dbcp2-version>
<commons-io-version>2.21.0</commons-io-version>
+ <commons-lang3-version>3.20.0</commons-lang3-version>
Review Comment:
I believe we'll always have custom buffer, io, and text handling classes due
to all the protocol and admin functionality due to the nature of operating a
performant broker. Part of the reason to re-home activemq-protobuf is to be
able to consolidate those classes UTF8Buffer, ASCIIBuffer, etc.. into a single
activemq-io module. We have a couple sets of these classes and custom stream
handlers across the project, and the hawt* dependencies. I think once those
classes are consolidated to a single module, it'll be more apparent.
I'm not opposed to adding this to the web console, b/c it is expedient and
the desire to overhaul/replace this broker.
However, I think adoption of wider use of third-party I/O dependencies
warrants a bigger discussion when it comes to client/broker usage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
