maheshk114 commented on a change in pull request #945: HIVE-22998 Dump 
partition info if hive.repl.dump.metadata.only.for.ex…
URL: https://github.com/apache/hive/pull/945#discussion_r391373822
 
 

 ##########
 File path: 
ql/src/java/org/apache/hadoop/hive/ql/exec/repl/bootstrap/load/table/LoadPartitions.java
 ##########
 @@ -129,7 +130,8 @@ public TaskTracker tasks() throws Exception {
       // existing
       if (table.isPartitioned()) {
         List<AlterTableAddPartitionDesc> partitionDescs = 
event.partitionDescriptions(tableDesc);
-        if (!event.replicationSpec().isMetadataOnly() && 
!event.replicationSpec().isMetadataOnlyForExternalTables()
+        if (!event.replicationSpec().isMetadataOnly()
+                && !Utils.shouldDumpMetaDataOnlyForExternalTables(table, 
context.hiveConf)
 
 Review comment:
   These all are load time functions ..i am not sure if we can use the config 
..it should be checked using replicationspec

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to