maheshk114 commented on a change in pull request #945: HIVE-22998 Dump
partition info if hive.repl.dump.metadata.only.for.ex…
URL: https://github.com/apache/hive/pull/945#discussion_r391377311
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/repl/dump/Utils.java
##########
@@ -200,7 +201,8 @@ public static boolean shouldReplicate(ReplicationSpec
replicationSpec, Table tab
if (MetaStoreUtils.isExternalTable(tableHandle.getTTable())) {
boolean shouldReplicateExternalTables =
hiveConf.getBoolVar(HiveConf.ConfVars.REPL_INCLUDE_EXTERNAL_TABLES)
- || replicationSpec.isMetadataOnly();
+ || replicationSpec.isMetadataOnly()
+ || Utils.shouldDumpMetaDataOnlyForExternalTables(tableHandle,
hiveConf);
Review comment:
The check is very specific to DAS ..it includes external table meta data
even if external table replication is not enabled ..i am not sure if we can
have same for this config also
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
