maheshk114 commented on a change in pull request #945: HIVE-22998 Dump
partition info if hive.repl.dump.metadata.only.for.ex…
URL: https://github.com/apache/hive/pull/945#discussion_r391439953
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/parse/repl/dump/TableExport.java
##########
@@ -75,11 +75,20 @@ public TableExport(Paths paths, TableSpec tableSpec,
ReplicationSpec replication
? null
: tableSpec;
this.replicationSpec = replicationSpec;
- if (this.tableSpec != null && this.tableSpec.tableHandle!=null &&
(this.tableSpec.tableHandle.isView() ||
- Utils.shouldDumpMetaDataOnly(this.tableSpec.tableHandle, conf))) {
- this.replicationSpec.setIsMetadataOnly(true);
-
- this.tableSpec.tableHandle.setStatsStateLikeNewTable();
+ if (this.tableSpec != null && this.tableSpec.tableHandle!=null) {
+ //If table is view or if should dump metadata only flag used by DAS is
set to true
+ //enable isMetadataOnly
+ if (this.tableSpec.tableHandle.isView() ||
Utils.shouldDumpMetaDataOnly(conf)) {
+ this.tableSpec.tableHandle.setStatsStateLikeNewTable();
+ this.replicationSpec.setIsMetadataOnly(true);
+ }
+ //If table is view or if should dump metadata only for external table
flag is set to true
+ //enable isMetadataOnlyForExternalTable
+ if (this.tableSpec.tableHandle.isView()
+ ||
Utils.shouldDumpMetaDataOnlyForExternalTables(this.tableSpec.tableHandle,
conf)) {
+ this.tableSpec.tableHandle.setStatsStateLikeNewTable();
+ this.replicationSpec.setMetadataOnlyForExternalTables(true);
Review comment:
No where this flag is accessed ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
