odraese commented on a change in pull request #944: [Hive-22760] Adding Clock
based eviction strategy.
URL: https://github.com/apache/hive/pull/944#discussion_r400362498
##########
File path:
llap-server/src/java/org/apache/hadoop/hive/llap/cache/LowLevelLrfuCachePolicy.java
##########
@@ -491,29 +499,32 @@ private int moveMinChildUp(int targetPos, long time,
double comparePri) {
}
if (leftPri <= rightPri) { // prefer left, cause right might be missing
heap[targetPos] = left;
- left.indexInHeap = targetPos;
+ LrfuCacheAttribute leftCacheAttribute = (LrfuCacheAttribute)
left.cacheAttribute;
+ leftCacheAttribute.indexInHeap = targetPos;
Review comment:
would hope that the compiler is optimized to inline the setter code. Using
setter makes it better encapsulated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
