prasanthj commented on a change in pull request #944: [Hive-22760] Adding Clock based eviction strategy. URL: https://github.com/apache/hive/pull/944#discussion_r400414707
########## File path: llap-server/src/java/org/apache/hadoop/hive/llap/cache/CacheAttribute.java ########## @@ -0,0 +1,42 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.hive.llap.cache; + +/** + * Cache attributes Interface to allow sophisticated cache policy add their api without adding memory overhead. + */ +public interface CacheAttribute { + /** + * @return buffer priority (actual semantic is up to {@link LowLevelCachePolicy}). + */ + double getPriority(); + void setPriority(double priority); + + /** + * @return actual time where the buffer was touched last. + */ + long getLastUpdate(); + void setTouchTime(long time); Review comment: nit: add interface doc for the public methods? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
