prasanthj commented on a change in pull request #944: [Hive-22760] Adding Clock
based eviction strategy.
URL: https://github.com/apache/hive/pull/944#discussion_r400490326
##########
File path:
llap-server/src/java/org/apache/hadoop/hive/llap/cache/LowLevelCachePolicy.java
##########
@@ -26,6 +28,32 @@
*/
public interface LowLevelCachePolicy extends LlapIoDebugDump {
+ static LowLevelCachePolicy provideFromConf(Configuration conf) {
+ final long totalMemorySize = HiveConf.getSizeVar(conf,
HiveConf.ConfVars.LLAP_IO_MEMORY_MAX_SIZE);
+ final int minAllocSize = (int) HiveConf.getSizeVar(conf,
HiveConf.ConfVars.LLAP_ALLOCATOR_MIN_ALLOC);
+ String policyName =
HiveConf.getVar(conf,HiveConf.ConfVars.LLAP_IO_CACHE_STRATEGY);
Review comment:
or make the policy name lowercase here to be case insensitive always?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
