jcamachor commented on a change in pull request #952: HIVE-23006 ProbeDecode 
compiler support
URL: https://github.com/apache/hive/pull/952#discussion_r405770526
 
 

 ##########
 File path: ql/src/java/org/apache/hadoop/hive/ql/parse/GenTezUtils.java
 ##########
 @@ -196,6 +196,11 @@ public MapWork createMapWork(GenTezProcContext context, 
Operator<?> root,
       mapWork.setIncludedBuckets(ts.getConf().getIncludedBuckets());
     }
 
+    if (ts.getProbeDecodeContext() != null) {
+      // TODO: some operators like VectorPTFEvaluator do not allow the use of 
Selected take this into account here?
 
 Review comment:
   I think this may be taken into account when we are pushing the SJ predicates 
down since it would not be valid in that case either (which I believe your 
logic to create the context is relying on?). Could you verify that?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to