pgaref commented on a change in pull request #952: HIVE-23006 ProbeDecode
compiler support
URL: https://github.com/apache/hive/pull/952#discussion_r406157569
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/optimizer/SharedWorkOptimizer.java
##########
@@ -487,6 +487,15 @@ private static boolean
sharedWorkOptimization(ParseContext pctx, SharedWorkOptim
}
LOG.debug("Input operator removed: {}", op);
}
+
+ // A shared TSop across branches can not have probeContext that
utilizes single branch info
+ // Filtered-out rows from one branch might be needed by another
branch sharing a TSop
+ if (retainableTsOp.getProbeDecodeContext() != null) {
Review comment:
I am not sure there is a good way to check how selective these filters are
especially when using MJ HT probing (available at runtime at non-deterministic
times) thus I chose to disable the optimization.
Maybe an actual decision (merging TS or not) could be made when we deal with
actual static filters that can be more predictable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
