pgaref commented on a change in pull request #952: HIVE-23006 ProbeDecode
compiler support
URL: https://github.com/apache/hive/pull/952#discussion_r406161694
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/GenTezUtils.java
##########
@@ -196,6 +196,11 @@ public MapWork createMapWork(GenTezProcContext context,
Operator<?> root,
mapWork.setIncludedBuckets(ts.getConf().getIncludedBuckets());
}
+ if (ts.getProbeDecodeContext() != null) {
+ // TODO: some operators like VectorPTFEvaluator do not allow the use of
Selected take this into account here?
Review comment:
Just to clarify, I am referring to this Precondition check that is used by
all PTF operators.
As this optimization enables TS filtering by setting selectedInUse down the
pipeline it could make these PreConditions to fail.
We could take this into account when adding valid MJ-TS ops indeed, however
it could be still beneficial for other operators on the pipeline that do use
the selected array.
So the real question: is the condition really needed on those operators?
It does not look to me that it could cause any issues if it is enabled (even
if PTF ops dont use it)
https://github.com/apache/hive/blob/cc38bcc5a993304898ba37b8496f13a15d62bf16/ql/src/java/org/apache/hadoop/hive/ql/exec/vector/ptf/VectorPTFEvaluatorDecimalAvg.java#L64
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
