pgaref commented on a change in pull request #1063:
URL: https://github.com/apache/hive/pull/1063#discussion_r436063677
##########
File path:
storage-api/src/java/org/apache/hive/common/util/SuppressFBWarnings.java
##########
@@ -0,0 +1,19 @@
+package org.apache.hive.common.util;
+
+import java.lang.annotation.Retention;
+import java.lang.annotation.RetentionPolicy;
+
+@Retention(RetentionPolicy.CLASS)
+public @interface SuppressFBWarnings {
Review comment:
Hey @mustafaiman -- in the main pom.xml we are only using the
finbugs-maven-plugin and not the findbugs-annotation package (only hive-ql is
using it as dependency and I would like to remove it eventually).
In order to avoid adding just another dependency (findbugs-annotation), I
implemented the annotation as a separate class, Findbugs doesn't care in which
package the annotation is, so it works pretty well -- we can also reuse it
across hive packages.
https://sourceforge.net/p/findbugs/feature-requests/298/#5e88
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
