mustafaiman commented on a change in pull request #1063:
URL: https://github.com/apache/hive/pull/1063#discussion_r436076795



##########
File path: 
storage-api/src/java/org/apache/hive/common/util/SuppressFBWarnings.java
##########
@@ -0,0 +1,19 @@
+package org.apache.hive.common.util;
+
+import java.lang.annotation.Retention;
+import java.lang.annotation.RetentionPolicy;
+
+@Retention(RetentionPolicy.CLASS)
+public @interface SuppressFBWarnings {

Review comment:
       If we are defining our own annotation, I would like to put it in a 
common to prevent each module having their own copy of the same annotation. I 
thought hive-common would be a good candidate but storage-api does not depend 
on hive-common either. This looks like the only way then. Thanks for the link.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to