belugabehr commented on a change in pull request #1063:
URL: https://github.com/apache/hive/pull/1063#discussion_r436118081
##########
File path:
storage-api/src/java/org/apache/hadoop/hive/common/io/encoded/EncodedColumnBatch.java
##########
@@ -78,13 +78,13 @@ public void setIndexBaseOffset(int indexBaseOffset) {
@Override
public String toString() {
- String bufStr = "";
+ StringBuffer bufStr = new StringBuffer();
if (cacheBuffers != null) {
for (MemoryBuffer mb : cacheBuffers) {
- bufStr += mb.getClass().getSimpleName() + " with " +
mb.getByteBufferRaw().remaining() + " bytes, ";
+ bufStr.append(mb.getClass().getSimpleName() + " with " +
mb.getByteBufferRaw().remaining() + " bytes, ");
Review comment:
I think it's a little bit more than this. There shouldn't be any "+"
concatenation. Should all be `.append()`
I already proposed to addressed this issue (HIVE-23540), but happy to defer
to this PR
https://issues.apache.org/jira/browse/HIVE-23540
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
