marton-bod commented on a change in pull request #2226:
URL: https://github.com/apache/hive/pull/2226#discussion_r622090465
##########
File path: iceberg/pom.xml
##########
@@ -51,14 +52,24 @@
<dependencies>
<dependency>
<groupId>org.apache.iceberg</groupId>
- <artifactId>iceberg-api</artifactId>
+ <artifactId>patched-iceberg-api</artifactId>
<version>patched-${iceberg-api.version}-${project.parent.version}</version>
</dependency>
<dependency>
<groupId>org.apache.iceberg</groupId>
- <artifactId>iceberg-core</artifactId>
+ <artifactId>patched-iceberg-core</artifactId>
<version>patched-${iceberg-api.version}-${project.parent.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.iceberg</groupId>
+ <artifactId>iceberg-api</artifactId>
+ <version>${iceberg-api.version}</version>
Review comment:
not completely related to this PR, but why isn't this just
`iceberg.version`? I guess there shouldn't be different version for
iceberg-api, iceberg-data, etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
