szlta commented on a change in pull request #2226:
URL: https://github.com/apache/hive/pull/2226#discussion_r622101728
##########
File path: iceberg/pom.xml
##########
@@ -51,14 +52,24 @@
<dependencies>
<dependency>
<groupId>org.apache.iceberg</groupId>
- <artifactId>iceberg-api</artifactId>
+ <artifactId>patched-iceberg-api</artifactId>
<version>patched-${iceberg-api.version}-${project.parent.version}</version>
</dependency>
<dependency>
<groupId>org.apache.iceberg</groupId>
- <artifactId>iceberg-core</artifactId>
+ <artifactId>patched-iceberg-core</artifactId>
<version>patched-${iceberg-api.version}-${project.parent.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.iceberg</groupId>
+ <artifactId>iceberg-api</artifactId>
+ <version>${iceberg-api.version}</version>
Review comment:
Hm yeah it should be iceberg.version everywhere, but I was just
following suit with this one, as I see the -api version being used in all poms.
Maybe we could address this in separate jira.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
