szlta commented on a change in pull request #2226: URL: https://github.com/apache/hive/pull/2226#discussion_r622100140
########## File path: iceberg/iceberg-shading/pom.xml ########## @@ -0,0 +1,147 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + Licensed under the Apache License, Version 2.0 (the "License"); + you may not use this file except in compliance with the License. + You may obtain a copy of the License at + http://www.apache.org/licenses/LICENSE-2.0 + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. +--> +<project xmlns="http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + <parent> + <groupId>org.apache.hive</groupId> + <artifactId>hive-iceberg</artifactId> + <version>4.0.0-SNAPSHOT</version> + <relativePath>../pom.xml</relativePath> + </parent> + <modelVersion>4.0.0</modelVersion> + + <artifactId>hive-iceberg-shading</artifactId> + <packaging>jar</packaging> + <name>Hive Iceberg Shading</name> + <description> + This module collects all required Iceberg modules and their dependencies, and shades them. + Consuming modules only need to mark this module as their dependency to get any required Iceberg libs. + This module has no sources of its own, only the built jar file contains the gathered and shaded libs. + For Intellij this module is recommended to be ignored, to avoid the dependent modules considering this as a + module dependency, they should see this as a library dependency instead. + </description> + + <properties> + <hive.path.to.root>../..</hive.path.to.root> + <path.to.iceberg.root>..</path.to.iceberg.root> + <shade.relocation.package.prefix>org.apache.hive.iceberg</shade.relocation.package.prefix> + </properties> + + <dependencies> + <dependency> + <groupId>org.apache.iceberg</groupId> + <artifactId>patched-iceberg-core</artifactId> + </dependency> + <dependency> + <groupId>org.apache.iceberg</groupId> + <artifactId>iceberg-data</artifactId> + <optional>true</optional> + </dependency> + <dependency> + <groupId>org.apache.iceberg</groupId> + <artifactId>iceberg-parquet</artifactId> + <optional>true</optional> + </dependency> + <dependency> + <groupId>org.apache.iceberg</groupId> + <artifactId>iceberg-orc</artifactId> + <optional>true</optional> + </dependency> + </dependencies> + + <profiles> + <profile> + <id>shaded-build</id> + <activation> + <property> + <name>skipShade</name> + <value>!true</value> + </property> + </activation> + <build> + <plugins> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-shade-plugin</artifactId> + <executions> + <execution> + <phase>package</phase> + <goals> + <goal>shade</goal> + </goals> + <configuration> + <createDependencyReducedPom>false</createDependencyReducedPom> + <relocations> + <relocation> + <pattern>org.apache.avro</pattern> + <shadedPattern>${shade.relocation.package.prefix}.org.apache.avro</shadedPattern> + </relocation> + <relocation> + <pattern>org.apache.orc</pattern> + <shadedPattern>${shade.relocation.package.prefix}.org.apache.orc</shadedPattern> + </relocation> + <relocation> + <pattern>org.apache.parquet</pattern> + <shadedPattern>${shade.relocation.package.prefix}.org.apache.parquet</shadedPattern> + </relocation> + <relocation> + <pattern>shaded.parquet</pattern> + <shadedPattern>${shade.relocation.package.prefix}.shaded.parquet</shadedPattern> + </relocation> + <relocation> + <pattern>com.google</pattern> + <shadedPattern>${shade.relocation.package.prefix}.com.google</shadedPattern> + </relocation> + <relocation> + <pattern>com.fasterxml</pattern> + <shadedPattern>${shade.relocation.package.prefix}.com.fasterxml</shadedPattern> + </relocation> + <relocation> + <pattern>com.github.benmanes</pattern> + <shadedPattern>${shade.relocation.package.prefix}.com.github.benmanes</shadedPattern> + </relocation> + </relocations> + <artifactSet> + <includes> + <include>org.apache.iceberg:*</include> + <include>org.apache.hive:hive-iceberg-catalog</include> Review comment: Ah good catch that's a benign leftover, it's a noop whitelist entry in this case, as the related classes are not there yet during the build time of iceberg-shading. I'll remove it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
