marton-bod commented on a change in pull request #2317:
URL: https://github.com/apache/hive/pull/2317#discussion_r640370818



##########
File path: 
iceberg/iceberg-handler/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergStorageHandlerNoScan.java
##########
@@ -462,7 +493,7 @@ public void testCreateTableWithNotSupportedTypes() {
           "Unsupported Hive type", () -> {
             shell.executeStatement("CREATE EXTERNAL TABLE not_supported_types 
" +
                 "(not_supported " + notSupportedType + ") " +
-                "STORED BY 
'org.apache.iceberg.mr.hive.HiveIcebergStorageHandler' " +
+                "STORED BY ICEBERG " +

Review comment:
       Did we leave some test cases with the orginal syntax `STORED BY 
'org.apache.iceberg.mr.hive.HiveIcebergStorageHandler'` to make sure it's still 
working?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to