marton-bod commented on a change in pull request #2317:
URL: https://github.com/apache/hive/pull/2317#discussion_r640381488
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/StorageFormat.java
##########
@@ -93,6 +106,14 @@ public boolean fillStorageFormat(ASTNode child) throws
SemanticException {
return true;
}
+ private String processStorageHandler(String name) throws SemanticException {
+ if (StorageHandlerTypes.ICEBERG.name().equalsIgnoreCase(name)) {
Review comment:
I think the code change to make it generic would be very small, probably
a 4-line for loop, so we might as well add it into this PR, but I don't feel
strongly, just a suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
