marton-bod commented on a change in pull request #2317:
URL: https://github.com/apache/hive/pull/2317#discussion_r640374426
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/StorageFormat.java
##########
@@ -93,6 +106,14 @@ public boolean fillStorageFormat(ASTNode child) throws
SemanticException {
return true;
}
+ private String processStorageHandler(String name) throws SemanticException {
+ if (StorageHandlerTypes.ICEBERG.name().equalsIgnoreCase(name)) {
Review comment:
Shall we make this generic so it works for future StorageHandlerTypes
types? i.e. iterate through the enum values and if `name` matches any enum
value, then reset the `name` with `enum.name()` accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
