kovjanos commented on PR #3214:
URL: https://github.com/apache/hive/pull/3214#issuecomment-1100754582

   @zabetak  Tested with  Derby, MySQL, PostgreSQL and MSSQL and worked - see 
below. 
   Oracle doesn't work, I need to review again. 
   
   Versions tested:
   ```
   az82/docker-derby
   mysql:5.7
   postgres:11.6
   mcr.microsoft.com/mssql/server:2019-latest
   ```
   
   Derby
   ```
   CREATE TABLE TEST_TABLE (
     ID  bigint NOT NULL,
     DB  varchar(10) NOT NULL
   );
   CREATE INDEX TEST_TABLE_IDX ON TEST_TABLE (DB);
   INSERT INTO TEST_TABLE VALUES (1,'1-db'),(2,'2-db'),(3,'3-db');
   ALTER TABLE TEST_TABLE ADD COLUMN PKEY bigint PRIMARY KEY GENERATED BY 
DEFAULT AS IDENTITY;
   SELECT * FROM TEST_TABLE;
   INSERT INTO TEST_TABLE (ID,DB) VALUES (4,'4-db'),(5,'5-db'),(6,'6-db');
   SELECT * FROM TEST_TABLE;
   ```
   
   PostgreSQL:
   ```
   CREATE TABLE "TEST_TABLE" (
     "ID"  bigint NOT NULL,
     "DB"  varchar(10) NOT NULL);
   CREATE INDEX TEST_TABLE_IDX ON "TEST_TABLE" USING btree ("DB");
   INSERT INTO "TEST_TABLE" VALUES (1,'1-db'),(2,'2-db'),(3,'3-db');
   ALTER TABLE "TEST_TABLE" ADD "PKEY" bigserial PRIMARY KEY;
   SELECT * FROM "TEST_TABLE";
   INSERT INTO "TEST_TABLE" VALUES (4,'4-db'),(5,'5-db'),(6,'6-db');
   SELECT * FROM "TEST_TABLE";
   ```
   
   MySQL: 
   ```
   CREATE TABLE TEST_TABLE (
     ID  bigint NOT NULL,
     DB  varchar(10) NOT NULL
   ) ENGINE=InnoDB DEFAULT CHARSET=latin1;
   CREATE INDEX TEST_TABLE_IDX ON TEST_TABLE (DB) USING BTREE;
   INSERT INTO TEST_TABLE VALUES (1,'1-db'),(2,'2-db'),(3,'3-db');
   ALTER TABLE TEST_TABLE ADD COLUMN PKEY BIGINT NOT NULL PRIMARY KEY 
AUTO_INCREMENT FIRST;
   SELECT * FROM TEST_TABLE;
   INSERT INTO TEST_TABLE (ID,DB) VALUES (4,'4-db'),(5,'5-db'),(6,'6-db');
   SELECT * FROM TEST_TABLE;
   ```
   
   MSSQL: 
   ```
   CREATE TABLE TEST_TABLE (
     ID  bigint NOT NULL,
     DB  varchar(10) NOT NULL
   );
   CREATE INDEX TEST_TABLE_IDX ON TEST_TABLE (DB);
   INSERT INTO TEST_TABLE VALUES (1,'1-db'),(2,'2-db'),(3,'3-db');
   ALTER TABLE TEST_TABLE ADD PKEY bigint NOT NULL IDENTITY(1,1) PRIMARY KEY;
   SELECT * FROM TEST_TABLE;
   INSERT INTO TEST_TABLE VALUES (1,'1-db'),(2,'2-db'),(3,'3-db');
   SELECT * FROM TEST_TABLE;
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to