kovjanos commented on code in PR #3214: URL: https://github.com/apache/hive/pull/3214#discussion_r890895066
########## standalone-metastore/metastore-server/src/main/sql/derby/hive-schema-4.0.0-alpha-2.derby.sql: ########## @@ -570,7 +571,8 @@ CREATE TABLE COMPLETED_TXN_COMPONENTS ( CTC_PARTITION varchar(767), CTC_TIMESTAMP timestamp DEFAULT CURRENT_TIMESTAMP NOT NULL, CTC_WRITEID bigint, - CTC_UPDATE_DELETE char(1) NOT NULL + CTC_UPDATE_DELETE char(1) NOT NULL, + CTC_ID bigint PRIMARY KEY GENERATED BY DEFAULT AS IDENTITY Review Comment: Thanks for the review @deniskuzZ! Based on the above tests, that's only a problem for Oracle as others - Derby, PgSQL, MySQL, MSSQL - all generate uniq value for the multi-line inserts. As soon as out from other ticket I'll test the Oracle case if the cleaner queries do better plans or not with the identity to see if a sequence based column would be needed or just an identity column to keep schema consistent across all engines. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
