deniskuzZ commented on code in PR #3214: URL: https://github.com/apache/hive/pull/3214#discussion_r891212351
########## standalone-metastore/metastore-server/src/main/sql/derby/hive-schema-4.0.0-alpha-2.derby.sql: ########## @@ -570,7 +571,8 @@ CREATE TABLE COMPLETED_TXN_COMPONENTS ( CTC_PARTITION varchar(767), CTC_TIMESTAMP timestamp DEFAULT CURRENT_TIMESTAMP NOT NULL, CTC_WRITEID bigint, - CTC_UPDATE_DELETE char(1) NOT NULL + CTC_UPDATE_DELETE char(1) NOT NULL, + CTC_ID bigint PRIMARY KEY GENERATED BY DEFAULT AS IDENTITY Review Comment: oh, sorry that's not a TXN_ID column, might be worse to check `HIVE-23048: Use sequences for TXN_ID generation`. What are the problematic queries that could benefit from TC_ID/CTC_ID PK? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
