dengzhhu653 commented on code in PR #4320:
URL: https://github.com/apache/hive/pull/4320#discussion_r1193790927
##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/create/CreateTableDesc.java:
##########
@@ -937,7 +936,8 @@ public Table toTable(HiveConf conf) throws HiveException {
tbl.getTTable().getDictionary() : new ObjectDictionary();
List<ByteBuffer> buffers = new ArrayList<>();
String statsSetup =
StatsSetupConst.ColumnStatsSetup.getStatsSetupAsString(true,
- storageHandler != null &&
storageHandler.isMetadataTableSupported() ? "metadata" : null, // Skip metadata
directory for Iceberg table
+ // Is it an Iceberg table? ignore all leftover files
+ storageHandler != null &&
storageHandler.isMetadataTableSupported(),
Review Comment:
Thank you for the comment. The `storageHandler.isMetadataTableSupported()`
is only enabled in Iceberg table currently,
checking with the storage handler APIs, there is no such api to tell whether
the table is Iceberg based or not.
I'm also thinking of checking whether the `storageHandler ` belongs to
Iceberg storage handler, but that is too Iceberg specified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
