zhangbutao commented on code in PR #4320:
URL: https://github.com/apache/hive/pull/4320#discussion_r1193800879
##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/create/CreateTableDesc.java:
##########
@@ -937,7 +936,8 @@ public Table toTable(HiveConf conf) throws HiveException {
tbl.getTTable().getDictionary() : new ObjectDictionary();
List<ByteBuffer> buffers = new ArrayList<>();
String statsSetup =
StatsSetupConst.ColumnStatsSetup.getStatsSetupAsString(true,
- storageHandler != null &&
storageHandler.isMetadataTableSupported() ? "metadata" : null, // Skip metadata
directory for Iceberg table
+ // Is it an Iceberg table? ignore all leftover files
+ storageHandler != null &&
storageHandler.isMetadataTableSupported(),
Review Comment:
https://github.com/apache/hive/blob/e2b36e4449506b632e4fb68cd4f48f9a572407ee/ql/src/java/org/apache/hadoop/hive/ql/ddl/DDLUtils.java#L224-L225
yes, `storageHandler.isMetadataTableSupported()` is only used for icebeg
now. But in current Hive code, we often use snippet like this to check iceberg
table.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
