deniskuzZ commented on code in PR #4320:
URL: https://github.com/apache/hive/pull/4320#discussion_r1194890434
##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/create/CreateTableDesc.java:
##########
@@ -937,7 +936,9 @@ public Table toTable(HiveConf conf) throws HiveException {
tbl.getTTable().getDictionary() : new ObjectDictionary();
List<ByteBuffer> buffers = new ArrayList<>();
String statsSetup =
StatsSetupConst.ColumnStatsSetup.getStatsSetupAsString(true,
- storageHandler != null &&
storageHandler.isMetadataTableSupported() ? "metadata" : null, // Skip metadata
directory for Iceberg table
+ // Ignore all Iceberg leftover files when
storageHandler.canProvideBasicStatistics() is true,
+ // as the method is only enabled in Iceberg currently.
+ storageHandler != null &&
storageHandler.canProvideBasicStatistics(),
Review Comment:
@dengzhhu653 Sorry, I didn't notice that you were using
'isMetadataTableSupported' to determine if the table is Iceberg, but not that
it can provide column stats.
`canProvideBasicStatistics` won't be the proper way for that check.
'isMetadataTableSupported' would be a better option here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
