kasakrisz opened a new pull request, #4356:
URL: https://github.com/apache/hive/pull/4356
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA:
https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g.,
'[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a
faster review.
-->
### What changes were proposed in this pull request?
Remove support of unquoted timestamp literals without type information in
filter expressions when pulling partition metadata from HMS.
### Why are the changes needed?
The filter expression is transferred from `hs2` to `hms` in byte array
format which is deserialized to `String`. Then this string is parsed via
`ANTLR` to build an `ExpressionTree` in HMS. The date literal is a suffix of
timestamp literal
https://github.com/apache/hive/blob/7bfc54ffc8baf5f3e7de326b750fe9355b11132b/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/parser/Filter.g#L530-L538
Timestamp literal also contains a space character which makes ANTLR unable
to parse the expression.
Unfortunately the unquoted date representation without type name is passed
by other legacy clients like older version of Spark so this patch makes the api
backward compatible.
Not supporting unquoted timestamp literals is not problematic since
timestamp support was only recently added.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
```
mvn test -Dtest=TestPartFilterExprUtil -pl
standalone-metastore/metastore-server -Drat.skip
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
