kasakrisz commented on code in PR #4356:
URL: https://github.com/apache/hive/pull/4356#discussion_r1211740858
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/parser/Filter.g:
##########
@@ -549,7 +549,6 @@ DateLiteral
TimestampLiteral
:
KW_TIMESTAMP '\'' TimestampString '\'' { extractTimestamp(getText()) !=
null }?
- | TimestampString { extractTimestamp(getText()) != null }?
Review Comment:
It seems that is possible with a slight change in you proposed rule.
Since the unquoted parts conflicts I had to move the unquoted ts branch to
always execute predicate.
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/PartFilterExprUtil.java:
##########
@@ -101,7 +102,8 @@ public static PartitionExpressionProxy
createExpressionProxy(Configuration conf)
* @param filter Filter.
* @return Expression tree. Null if there was an error.
*/
- private static ExpressionTree makeExpressionTree(String filter) throws
MetaException {
+ @VisibleForTesting
+ static ExpressionTree makeExpressionTree(String filter) throws MetaException
{
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
