kasakrisz commented on code in PR #4356:
URL: https://github.com/apache/hive/pull/4356#discussion_r1211740858


##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/parser/Filter.g:
##########
@@ -549,7 +549,6 @@ DateLiteral
 TimestampLiteral
     :
     KW_TIMESTAMP '\'' TimestampString '\'' { extractTimestamp(getText()) != 
null }?
-    | TimestampString { extractTimestamp(getText()) != null }?

Review Comment:
   It is possible with a slight change in you proposed rule.
   Since the unquoted parts conflicts I had to move the unquoted ts branch to 
always execute predicate.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to