aturoczy commented on code in PR #4424:
URL: https://github.com/apache/hive/pull/4424#discussion_r1232359085
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/monitoring/RenderStrategy.java:
##########
@@ -161,7 +166,8 @@ public void renderReport(String report) {
if (hiveServer2InPlaceProgressEnabled) {
LOGGER.info(report);
} else {
- monitor.console.printInfo(report);
+ String time = REPORT_DATE_TIME_FORMATTER.format(LocalDateTime.now());
Review Comment:
LocalDateTime won't be confusing? Just thinking how it will be look like if
a user will be EST but the server time will be PST.
Just try to imagine the output.
Overall the code is OK. Could you please move the jira in-progress state?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
