okumin commented on code in PR #4424:
URL: https://github.com/apache/hive/pull/4424#discussion_r1232397547
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/monitoring/RenderStrategy.java:
##########
@@ -161,7 +166,8 @@ public void renderReport(String report) {
if (hiveServer2InPlaceProgressEnabled) {
LOGGER.info(report);
} else {
- monitor.console.printInfo(report);
+ String time = REPORT_DATE_TIME_FORMATTER.format(LocalDateTime.now());
Review Comment:
I followed the behavior of MapReduce since I actually wrote this patch while
I was migrating Hive on MR on Hive on Tez.
- MR: It uses [the default
Calendar](https://github.com/apache/hive/blob/31c1658d9884eb4f31b06eaa718dfef8b1d92d22/ql/src/java/org/apache/hadoop/hive/ql/exec/mr/HadoopJobExecHelper.java#L350)
which follows [the default time
zone](https://docs.oracle.com/javase/8/docs/api/java/util/Calendar.html#getInstance--)
Looking at other usages, it could be kinder to use
[HiveConf#getLocalTimeZone](https://github.com/apache/hive/blob/rel/release-4.0.0-alpha-2/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java#L6482-L6485).
Let me check and try it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
