okumin commented on code in PR #4424:
URL: https://github.com/apache/hive/pull/4424#discussion_r1232525651
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/monitoring/RenderStrategy.java:
##########
@@ -161,7 +166,8 @@ public void renderReport(String report) {
if (hiveServer2InPlaceProgressEnabled) {
LOGGER.info(report);
} else {
- monitor.console.printInfo(report);
+ String time = REPORT_DATE_TIME_FORMATTER.format(LocalDateTime.now());
Review Comment:
@aturoczy I updated it. I think it is reasonable since it is consistent with
other places such as [CURRENT_DATE
UDF](https://github.com/apache/hive/blob/rel/release-4.0.0-alpha-2/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFCurrentDate.java#L55).
I have also verified the property takes effect.
By default, the default one, UTC in this case, is used.
```
$ beeline -e 'SELECT sum(price) FROM orders' --hiveconf
hive.server2.in.place.progress=false
...
INFO : 2023-06-16 16:56:55,735 Map 1: -/- Reducer 2: 0/1
INFO : 2023-06-16 16:56:56,240 Map 1: 0/1 Reducer 2: 0/1
```
The same offset is used when we explicitly give `hive.local.time.zone=UTC`.
```
$ beeline -e 'SELECT sum(price) FROM orders' --hiveconf
hive.server2.in.place.progress=false --hiveconf hive.local.time.zone=UTC
...
INFO : 2023-06-16 16:59:44,985 Map 1: -/- Reducer 2: 0/1
INFO : 2023-06-16 16:59:45,995 Map 1: 0/1 Reducer 2: 0/1
```
Configuring other time zones, we see a date and time with the offset.
```
$ beeline -e 'SELECT sum(price) FROM orders' --hiveconf
hive.server2.in.place.progress=false --hiveconf
hive.local.time.zone=America/Los_Angeles
...
INFO : 2023-06-16 10:02:17,700 Map 1: -/- Reducer 2: 0/1
INFO : 2023-06-16 10:02:18,712 Map 1: 0/1 Reducer 2: 0/1
...
$ beeline -e 'SELECT sum(price) FROM orders' --hiveconf
hive.server2.in.place.progress=false --hiveconf hive.local.time.zone=Asia/Tokyo
...
INFO : 2023-06-17 02:03:21,041 Map 1: -/- Reducer 2: 0/1
INFO : 2023-06-17 02:03:22,050 Map 1: 0/1 Reducer 2: 0/1
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
