soumyakanti3578 commented on code in PR #4692:
URL: https://github.com/apache/hive/pull/4692#discussion_r1325375340
##########
serde/src/java/org/apache/hadoop/hive/serde2/AbstractSerDe.java:
##########
@@ -189,7 +192,7 @@ public Optional<Configuration> getConfiguration() {
@Override
public String toString() {
- return "AbstractSerDe [log=" + log + ", configuration=" + configuration +
", properties=" + properties
+ return "AbstractSerDe [log=" + getClassLogger() + ", configuration=" +
configuration + ", properties=" + properties
Review Comment:
Hi, just trying to understand, why do we need a getter for a static final
variable? Isn't using the object `log` simpler, and then you don't need to
override the method `getClassLogger()` everywhere?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
