ramesh0201 commented on code in PR #4692:
URL: https://github.com/apache/hive/pull/4692#discussion_r1329626563
##########
druid-handler/src/test/org/apache/hadoop/hive/druid/QTestDruidSerDe.java:
##########
@@ -27,12 +27,16 @@
import org.apache.druid.query.metadata.metadata.SegmentAnalysis;
import org.apache.druid.query.metadata.metadata.SegmentMetadataQuery;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
/**
* Druid SerDe to be used in tests.
*/
public class QTestDruidSerDe extends DruidSerDe {
+ public static final Logger log =
LoggerFactory.getLogger(QTestDruidSerDe.class.getName());
Review Comment:
Again I am not worried about the log in this file but rather in the parent
class that want to log the right instantiated class name. At
https://github.com/apache/hive/blob/cbd6363ce904ea9150a8e8591d60edfc6b4adea9/serde/src/java/org/apache/hadoop/hive/serde2/AbstractSerDe.java#L93
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
