zabetak commented on code in PR #4692:
URL: https://github.com/apache/hive/pull/4692#discussion_r1329964951
##########
accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/serde/AccumuloSerDe.java:
##########
@@ -54,6 +54,11 @@ public class AccumuloSerDe extends AbstractSerDe {
private static final Logger log =
LoggerFactory.getLogger(AccumuloSerDe.class);
+ @Override
+ public Logger getClassLogger() {
+ return log;
+ }
+
Review Comment:
How about the following?
```java
LOG.debug("{} initialized: [{}][{}]", getClass().getName(),
this.configuration, this.properties);
```
It will generate something like:
```
serde2.AbstractSerDe: OrcSerde initialized ...
```
which I believe reflects better what is happening. The message is logged in
`AbstractSerDe` class but the actual object is of `OrcSerde` type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
